Add libkv Username and Password #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This lets you configure the username/password params in libkv. This is definitely useful for etcd, but may not be obvious for others. The struct embedding makes it hard to hide in the other KV providers where it may not be so relevant. |
|
Refs #1075. |
emilevauge
requested changes
Apr 6, 2017
There was a problem hiding this comment.
Hey @tcolgate, thanks for your contribution!
Could you complete traefik.sample.toml and docs/toml.md, and then rebase ?
Other than than, looks good :)
|
@emilevauge Docs updated. |
|
@emilevauge rebased on master |
ldez
added
contributor/needs-resolve-conflicts
and removed
contributor/waiting-for-corrections
labels
ldez
approved these changes
Apr 28, 2017
ldez
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.