Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore missing pass host header annotation. #1581

Conversation

timoreimann
Copy link
Contributor

We are starting to see reports of people using 1.3-rc1 and complaining/wondering about the problem reported in #1548. Hence, I think we should include the fix in the 1.3 branch as well.

A missing annotation would previously be handled in the default error
case, causing a noisy warning-level log message to be generated each
time.

We add another case statement to ignore the case where the annotation is
missing from the annotations map.

Also piggybacking a minor improvement to the log message.
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

:shipit:

@timoreimann
Copy link
Contributor Author

@emilevauge LGTY?

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@timoreimann timoreimann merged commit d2b204a into traefik:v1.3 May 11, 2017
@timoreimann timoreimann deleted the 1-3-kubernetes-ignore-missing-pass-host-header-annotation branch May 11, 2017 15:43
@ldez ldez changed the title [Kubernetes] Ignore missing pass host header annotation. [v1.3 - CHERRY-PICK] [Kubernetes] Ignore missing pass host header annotation. May 11, 2017
@ldez ldez changed the title [Kubernetes] Ignore missing pass host header annotation. Ignore missing pass host header annotation. May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants