Upgrade go-marathon to 15ea23e. #1635
Merged
+126
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
added
area/provider/marathon
kind/bug/confirmed
timoreimann
force-pushed
the
upgrade-go-marathon-to-15ea23e
branch
2 times, most recently
from
ac59149
to
98f1f4d
Compare
|
ldez
added
kind/bug/fix
|
Interesting. I wonder why the mock fails now but did not do on the last go-marathon upgrade, which is ~2 commits behind and no API changes were introduced in the meantime AFAIR. Will take a look. Thanks, @ldez! |
ldez
reviewed
May 19, 2017
| // GetAppOpts contains a payload for Application method | ||
| // embed: Embeds nested resources that match the supplied path. | ||
| // You can specify this parameter multiple times with different values | ||
| type GetAppOpts struct { |
timoreimann
force-pushed
the
upgrade-go-marathon-to-15ea23e
branch
from
98f1f4d
to
c514def
Compare
|
Fixed, thanks to @ldez and |
emilevauge
approved these changes
May 22, 2017
Our vendored copy contains a bug that causes unavailable Marathon nodes to never be marked as available again due to a misconstruction in the URL to the Marathon health check / ping endpoint used by go-marathon internally. A fix[1] has been published. [1]gambol99/go-marathon#283
ldez
force-pushed
the
upgrade-go-marathon-to-15ea23e
branch
from
c514def
to
9aeffdf
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our vendored copy contains a bug that causes unavailable Marathon nodes to never be marked as available again due to a misconstruction in the URL to the Marathon health check / ping endpoint used by go-marathon internally.
A fix has been published.
Targeting 1.3 since the impact on a production deployment could be quite severe: For long-running Traefik instances, it only takes as many failed attempts to reach the Marathon API endpoint as there are Marathon nodes in the cluster for the Marathon provider to stop working properly.