Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marathon & Mesos providers' GroupsAsSubDomains option broken #867

Closed
ryanleary opened this issue Nov 22, 2016 · 1 comment
Closed

Marathon & Mesos providers' GroupsAsSubDomains option broken #867

ryanleary opened this issue Nov 22, 2016 · 1 comment
Labels
kind/bug/confirmed a confirmed bug (reproducible). priority/P0 needs hot fix status/5-frozen-due-to-age
Milestone
1.1

Comments

@ryanleary
Copy link
Contributor

Currently, the GroupsAsSubDomains option returns a reverse-sorted subdomain instead of a reverse-ordered subdomain.

As an example, if the application path is /d/c/b/a, the proper subdomain should be a.b.c.d (reversed). However, with the current implementation, the subdomain returned is d.c.b.a because it always returns in reverse sorted order.
@ryanleary ryanleary mentioned this issue Nov 22, 2016
Merged
@emilevauge emilevauge added the bug label Nov 24, 2016
@emilevauge emilevauge added this to the 1.1 milestone Nov 24, 2016
@emilevauge emilevauge added the priority/P0 needs hot fix label Nov 26, 2016
@emilevauge
Copy link
Member

Fixed by #868

@ldez ldez added the kind/bug/confirmed a confirmed bug (reproducible). label Apr 29, 2017
@traefik traefik locked and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug/confirmed a confirmed bug (reproducible). priority/P0 needs hot fix status/5-frozen-due-to-age
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
4 participants
@ryanleary @ldez @emilevauge @traefiker