Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fetch ACME certificates for frontends using non-TLS entrypoints (#989) #1023

Merged
merged 1 commit into from
Jan 6, 2017
Merged

Don't fetch ACME certificates for frontends using non-TLS entrypoints (#989) #1023

merged 1 commit into from
Jan 6, 2017

Conversation

matthmart
Copy link
Contributor

@matthmart matthmart commented Jan 6, 2017 •
edited by emilevauge
Loading

Fix for #989.

dtomcej
dtomcej approved these changes Jan 6, 2017
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@dtomcej
Copy link
Contributor

dtomcej commented Jan 6, 2017

ping @containous/traefik

vdemeester
vdemeester approved these changes Jan 6, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@vdemeester vdemeester merged commit 85b9c19 into traefik:master Jan 6, 2017
@dtomcej dtomcej mentioned this pull request Jan 6, 2017
Closed
@ldez ldez added kind/enhancement a new or improved feature. area/acme labels Apr 29, 2017
@ldez ldez added this to the 1.2 milestone Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
area/acme kind/enhancement a new or improved feature.
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@matthmart @dtomcej @vdemeester @ldez