Fix checkout initial before calling rmpr #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdemeester
approved these changes
Feb 6, 2017
| @@ -24,6 +24,7 @@ branch=$(curl -s https://api.github.com/repos/containous/traefik/pulls/$pr | jq | |||
|
|
|||
| clean () | |||
| { | |||
| git checkout $initial | |||
There was a problem hiding this comment.
If you call rmpr while you are checked out on your remote branch, rmpr will try to delete the branch you are on and it will fail. We have to checkout another branch before.
There was a problem hiding this comment.
I know 👼 🤔 <- that was for "why didn't I see that before" 😛
emilevauge
force-pushed
the
fix-git-rmpr
branch
from
63966b3
to
35ac9cd
Compare
Signed-off-by: Emile Vauge <emile@vauge.com>
emilevauge
force-pushed
the
fix-git-rmpr
branch
from
35ac9cd
to
556915c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Emile Vauge emile@vauge.com