Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in documentation for Docker labels #1179

Merged
merged 1 commit into from
Apr 23, 2017

Conversation

bgandon
Copy link
Contributor

@bgandon bgandon commented Feb 22, 2017

Hello,

Here is a fix in the documentation for an error I had spotted when working on a Docker Swarm project lastly.

Cheers

Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -799,7 +799,7 @@ swarmmode = false

Labels can be used on containers to override default behaviour:

- `traefik.backend=foo`: assign the container to `foo` backend
- `traefik.backend=foo`: give the name `backend-foo` to the generated backend for this container.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that's correct, even though the backend- prefix is just something the Docker template does and could be changed by users employing a customized template.

@timoreimann
Copy link
Contributor

@vdemeester easy one I guess.

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants