Motivate and explain regular expression rules. #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
force-pushed
the
elaborate-on-regexp
branch
from
754aff1
to
6f3331a
Compare
|
Looks great; thanks! |
|
LGTM 👍 |
emilevauge
approved these changes
Mar 2, 2017
timoreimann
force-pushed
the
elaborate-on-regexp
branch
from
6f3331a
to
6942b06
Compare
dtomcej
reviewed
Mar 2, 2017
docs/basics.md
Outdated
| @@ -85,13 +85,17 @@ Frontends can be defined using the following rules: | |||
| - `PathStrip`: Same as `Path` but strip the given prefix from the request URL's Path. | |||
| - `PathPrefix`: PathPrefix adds a matcher for the URL path prefixes. This matches if the given template is a prefix of the full URL path. | |||
| - `PathPrefixStrip`: Same as `PathPrefix` but strip the given prefix from the request URL's Path. | |||
| - `AddPrefix` : Add prefix from the request URL's Path. | |||
| - `AddPrefix`: Add prefix from the request URL's Path. | |||
There was a problem hiding this comment.
Sorry grammar question, shouldn't it be:
AddPrefix: Add prefix to the request URL's Path. ?
There was a problem hiding this comment.
Absolutely!
(Found another one too.)
|
@dtomcej okay to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nikore what do you think, is this good enough?
@containous/traefik PTAL.