Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker-compose labels for frontend and backend names #1235

Merged
merged 2 commits into from
Apr 3, 2017
Merged

Use docker-compose labels for frontend and backend names #1235

merged 2 commits into from
Apr 3, 2017

Conversation

tcoupin
Copy link
Contributor

@tcoupin tcoupin commented Mar 4, 2017

Actually with a project "foo" and service "bar", traefik add a frontend and a backend for each container (foo-bar-1, foo-bar-2...)

Now, frontend and backend are named foo-bar and all the instances of a service are grouped in a single backend.

@emilevauge
Copy link
Member

emilevauge commented Mar 7, 2017

Hey @tcoupin, I think this is a great idea :)
What about Host:{service}.{project_name}.{domain} instead of Host:{project_name}-{service}.{domain} ?
/cc @vdemeester

@tcoupin
Copy link
Contributor Author

tcoupin commented Mar 7, 2017 via email

@tcoupin
Copy link
Contributor Author

tcoupin commented Mar 9, 2017

Just commit "Use service.project.domain instead of project-service.domain"

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a huge fan of that (because it's only for docker-compose user, it won't work with docker stack deploy and if something like docker-compose uses a different namespace for labels it won't work and we might have to add more and more in the future) but I can see how it can make sense. So it's a weak LGTM 🐸 from me, but a LGTM still 👼

Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @tcoupin :)

@sarahconor
Copy link

Just upgraded to version 1.3.0 and this feature is causing me some issues. How can I default back the old behaviour (without changing dockerFiles) ? Host:{containerName}.{domain}

Thanks.

@ldez ldez added this to the 1.3 milestone May 19, 2017
@emilevauge
Copy link
Member

@sarahconor please, open an issue with a detailed description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants