-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use docker-compose labels for frontend and backend names #1235
Use docker-compose labels for frontend and backend names #1235
Conversation
Hey @tcoupin, I think this is a great idea :) |
Better
Le 7 mars 2017 15:56, "Emile Vauge" <notifications@github.com> a écrit :
Hey @tcoupin <https://github.com/tcoupin>, I think this is a great idea :)
What wbout Host:{service}.{project_name}.{domain} instead of
Host:{project_name}-{service}.{domain} ?
/cc @vdemeester <https://github.com/vdemeester>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1235 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHHKalo1HoAL9eCe4mfo-zuAWv-IbIKlks5rjXASgaJpZM4MTEuy>
.
|
Just commit "Use service.project.domain instead of project-service.domain" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a huge fan of that (because it's only for docker-compose user, it won't work with docker stack deploy
and if something like docker-compose uses a different namespace for labels it won't work and we might have to add more and more in the future) but I can see how it can make sense. So it's a weak LGTM 🐸 from me, but a LGTM still 👼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @tcoupin :)
Just upgraded to version 1.3.0 and this feature is causing me some issues. How can I default back the old behaviour (without changing dockerFiles) ? Host:{containerName}.{domain} Thanks. |
@sarahconor please, open an issue with a detailed description. |
Actually with a project "foo" and service "bar", traefik add a frontend and a backend for each container (foo-bar-1, foo-bar-2...)
Now, frontend and backend are named foo-bar and all the instances of a service are grouped in a single backend.