Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carry PR 1271 #1417

Merged
merged 1 commit into from
Apr 11, 2017
Merged

Carry PR 1271 #1417

merged 1 commit into from
Apr 11, 2017

Conversation

emilevauge
Copy link
Member

This PR carries #1271
Original work by @argeiger
Fixes #679

@emilevauge emilevauge added this to the 1.2 milestone Apr 11, 2017
@emilevauge emilevauge mentioned this pull request Apr 11, 2017
Closed
timoreimann
timoreimann approved these changes Apr 11, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming nothing changed from the original PR: Still LGTM.

@emilevauge emilevauge merged commit 82d6315 into v1.2 Apr 11, 2017
@emilevauge emilevauge mentioned this pull request Apr 12, 2017
Closed
@emilevauge emilevauge deleted the carry-pr-1271 branch April 12, 2017 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoreimann timoreimann timoreimann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@emilevauge @timoreimann @ldez @argeiger