-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: small documentation review #1516
Conversation
1cb4d82
to
5c1cdd3
Compare
docs/basics.md
Outdated
[frontends.frontend2] | ||
[frontends.frontend2.routes.test_1] | ||
rule = "Host:test1.localhost,test2.localhost" | ||
[frontends.frontend3] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra leading space?
annotation. By default if the annotation is not set at all Træfik will include the | ||
ingress. If the annotation is set to anything other than traefik or a blank string | ||
Træfik will ignore it. | ||
|
||
|
||
![](http://i.giphy.com/ujUdrdpX7Ok5W.gif) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why, but still
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣
5c1cdd3
to
5526028
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ldez
LGTM
5526028
to
4c4b05d
Compare
Description