Add Marathon guide. #1578
Add Marathon guide. #1578
Conversation
|
Refs #1250. |
timoreimann
changed the title
|
hey @stibbons, I went crazy and expanded what you have started to a full guide. Would you mind taking a look and tell me if it makes sense? |
|
ping @juliens |
|
Great! I don't know what I did but my review does not appear on Github "File changed". It is here: 2f7d104 |
Looks like you commented on a single commit instead of the entire change set. But don't worry, I see them. :-) Thanks for the feedback -- will address it soon! |
|
@stibbons Feedback incorporated. :-) |
|
LGTM. You might just want to point out the version of marathon that implements readiness checks Thanks for putting this together. |
|
@stibbons could you fix spelling? https://travis-ci.org/containous/traefik/jobs/230798308#L829 |
Good point -- I added the info for both the readiness checks and graceful termination handler. |
|
+1 |
|
|
||
| Traefik tries to detect the configured mode and route traffic to the right IP addresses. It is possible to force using task hosts with the `forceTaskHostname` option. | ||
|
|
||
| Given the complexity of the subject, it is possible that the heuristic fails. Apart from filing an issue and waiting for the feature request / bug report to get addressed, one workaround for such situations is to customize the Marathon template file to the individual needs. (Note that this does _not_ require rebuilding Traefik but only to point the `filename` configuration parameter to a customized version of the `marathon.tmpl` file on Traefik startup.) |
There was a problem hiding this comment.
We may need an example. I'm not sure all users can see what to do with template.
There was a problem hiding this comment.
I agree but would rather see the example in a more generic spot of the Traefik documentation since it applies to all providers. WDYT?
There was a problem hiding this comment.
I agree, and I realize yesterday that I can't find documentation on this.
One more todo ! 😉
There was a problem hiding this comment.
I have created #1590 to track the effort.
|
@juliens anything else you think is missing? Otherwise, I'd kindly ask for your LGTM. :-) |
|
/cc @containous/traefik for potential other reviewers. |
|
LGTM |
There was a problem hiding this comment.
Thanks a lot @stibbons !
LGTM
I suggest we change the base branch to v1.3 to get this right into the next release :)
Copy/pasted from very comprehensive slack response from @ttr https://traefik.slack.com/archives/C0CDT22PJ/p1494347929571784?thread_ts=1494339388.375916&cid=C0CDT22PJ Signed-off-by: Gaetan Semet <gaetan@xeberon.net>
|
Changed base branch to |
Copy/pasted from very comprehensive slack response from
@ttr@timoreimannhttps://traefik.slack.com/archives/C0CDT22PJ/p1494347929571784?thread_ts=1494339388.375916&cid=C0CDT22PJ
Signed-off-by: Gaetan Semet gaetan@xeberon.net