Ignore missing pass host header annotation. #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A missing annotation would previously be handled in the default error case, causing a noisy warning-level log message to be generated each time. We add another case statement to ignore the case where the annotation is missing from the annotations map. Also piggybacking a minor improvement to the log message.
ldez
approved these changes
May 10, 2017
|
@emilevauge LGTY? |
timoreimann
deleted the
1-3-kubernetes-ignore-missing-pass-host-header-annotation
branch
ldez
changed the title
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are starting to see reports of people using 1.3-rc1 and complaining/wondering about the problem reported in #1548. Hence, I think we should include the fix in the 1.3 branch as well.