Fix empty basic auth #1601
Merged
Fix empty basic auth #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilevauge
force-pushed
the
fix-fatal-auth
branch
from
a71e50e
to
3382454
Compare
ldez
approved these changes
May 15, 2017
timoreimann
reviewed
May 15, 2017
server/server.go
Outdated
| @@ -843,7 +844,7 @@ func (server *Server) buildDefaultHTTPRouter() *mux.Router { | |||
| return router | |||
| } | |||
|
|
|||
| func parseHealthCheckOptions(lb healthcheck.LoadBalancer, backend string, hc *types.HealthCheck, hcConfig HealthCheckConfig) *healthcheck.Options { | |||
| func parseHealthCheckOptions(lb healthcheck.LoadBalancer, backend string, hc *types.HealthCheck, hcConfig *HealthCheckConfig) *healthcheck.Options { | |||
There was a problem hiding this comment.
Do we guarantee on the call site that hcConfig is always != nil? Without that, we could run into a nil reference issue on line 852.
There was a problem hiding this comment.
Oops, I was thinking the same and I just saw you too :) Fixed.
|
Hmm, how's the health check configuration related to basic auth? I must be missing a piece of the puzzle... 🤔 |
emilevauge
force-pushed
the
fix-fatal-auth
branch
from
3382454
to
2b2ba27
Compare
|
@timoreimann You are absolutely right. I just fixed this because it failed while I was writing the new tests and I thought it would be safer to remove the pointer dereferencing calling |
Signed-off-by: Emile Vauge <emile@vauge.com>
emilevauge
force-pushed
the
fix-fatal-auth
branch
from
2b2ba27
to
eaedc1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes traefik crash when basic auth user is empty.
Fixes #1592