Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re Organise k8s docs to make 1.6 usage easier #1602

Merged
merged 1 commit into from
May 17, 2017
Merged

Re Organise k8s docs to make 1.6 usage easier #1602

merged 1 commit into from
May 17, 2017

Conversation

errm
Copy link
Contributor

@errm errm commented May 15, 2017

  • Adds some raw.githubusercontent.com links to the kubectl examples to
    make following along at home simpler.
  • Dedupe the config for rbac so it can just be omitted if not needed.

timoreimann
timoreimann reviewed May 15, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single GKE-related note, but otherwise 👍

docs/user-guide/kubernetes.md Outdated
of Kubernetes resources and api.

If your cluster is configured with RBAC, you need to authorize Traefik to use
kubernetes API using ClusterRole and ClusterRoleBinding resources:
Copy link
Contributor

@timoreimann timoreimann May 15, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this does not seem to be required on GKE: We're running a Traefik DaemonSet without any extra ServiceAccounts or ClusterRoles defined.

Maybe we could add a note saying something along the lines of

Note that on GKE, this may not be necessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't run 1.6 on GKE yet, but I would suspect that this is because the default service account for whatever namespace you are running this on already has a role with sufficient privileges.

This config is good because it gives an example of what will work for sure rather than depending on something that has already been setup.

@errm errm force-pushed the k8s-1.6-docs-improvements branch from a8b0006 to b07367e Compare May 16, 2017 12:37
@errm
Copy link
Contributor Author

errm commented May 16, 2017

Ok @timoreimann I added a generic note as I think your comment probably applies to many installations not just GKE

timoreimann
timoreimann approved these changes May 16, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny little remark, but nevertheless LGTM'ing already. :-)

docs/user-guide/kubernetes.md Outdated
If your cluster is configured with RBAC, you may need to authorize Traefik to use
kubernetes API using ClusterRole and ClusterRoleBinding resources:

_Note: your cluster may already have suitable ClusterRoles already setup, but the following should work everywhere_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already mentioned twice. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

derp...

@errm errm force-pushed the k8s-1.6-docs-improvements branch from b07367e to b0a572d Compare May 16, 2017 14:04
emilevauge
emilevauge approved these changes May 17, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @errm
LGTM

@emilevauge
Copy link
Member

I suggest we change the base branch to v1.3 to get this right into the next release :)

@emilevauge emilevauge changed the base branch from master to v1.3 May 17, 2017 13:19
@emilevauge emilevauge changed the base branch from v1.3 to master May 17, 2017 13:22
@errm @emilevauge
Re Orginise k8s docs to make 1.6 usage easier
c944d48 
* Adds some raw.githubusercontent.com links to the kubectl examples to
make following along at home simpler.
* Dedupe the config for rbac so it can just be ommited if not needed.
@emilevauge
Copy link
Member

Changed base branch to containous:v1.3 and rebased.

@emilevauge emilevauge changed the base branch from master to v1.3 May 17, 2017 13:26
@emilevauge emilevauge merged commit c1220b8 into traefik:v1.3 May 17, 2017
@ldez ldez added this to the 1.3 milestone May 19, 2017
@ldez ldez changed the title Re Orginise k8s docs to make 1.6 usage easier Re Organise k8s docs to make 1.6 usage easier May 26, 2017
@ldez ldez mentioned this pull request Jun 2, 2017
Closed
@errm errm deleted the k8s-1.6-docs-improvements branch September 28, 2017 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilevauge emilevauge emilevauge approved these changes

@ldez ldez ldez approved these changes

@timoreimann timoreimann timoreimann approved these changes

@dtomcej dtomcej Awaiting requested review from dtomcej

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/ingress
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@errm @emilevauge @timoreimann @ldez