make the cookie name unique to the backend being served #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/sticky-session
kind/enhancement
|
This makes upgrading traefik version harder because it looks not to be backwards compatible. Imagine an ongoing sticky websocket connection. On upgrade it will reconnect but does not have this cookie any more (name changed). So the reconnected user may end up on a different server. Also gradual rollout where you have some of the instances running old version and some new may cause some issues. This is not a problem for my case as we're also using custom header stickyness https://github.com/salemove/traefik/commit/9f8adf2b30baec6eebb58fad862dc7760c1de17c but may be a problem for others. |
This was referenced Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set cookie name so that it is unique to the backend.
Addresses issue #1574.
See PR #1712 for additional discussion.