Fix fallback to other nodes for Marathon #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3co-code
force-pushed
the
issue-659-go-marathon-update
branch
from
af5a00a
to
6dea861
Compare
|
The |
m3co-code
force-pushed
the
issue-659-go-marathon-update
branch
from
6dea861
to
4ac6b69
Compare
timoreimann
approved these changes
Jun 13, 2017
in order to get the latest fixes regarding SSE subscription failover.
m3co-code
force-pushed
the
issue-659-go-marathon-update
branch
from
4ac6b69
to
9091f2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the issue #659. The fix is actually in
github.com/gambol99/go-marathonand this PR updates it and its sub-dependencygithub.com/donovanhide/eventsource.I updated the dependency according to the approach @timoreimann suggested here. I tested the failover with Traefik against a real running Marathon cluster and took nodes down one after another. Also I tried to take all nodes down at once and see if it recovers and the failover/recovery works consistently.
Fixes #659