Add status code to request duration metric #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/middleware/metrics
kind/enhancement
ldez
force-pushed
the
add-status-code-to-req-duration-metric
branch
from
6219e7f
to
0ad822c
Compare
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its best practice to monitor request durations partitioned by the status code of the response. 4xx/5xx usually have a different response time then succeeding requests. In case of 4xx they are most of the time very fast and depending on the type of server error, 5xx are also either very fast or very slow. Having no differentiation of those would distort calculations on the request durations, e.g. when you want to calculate an average.
Adding the label to the metric is not breaking existing Prometheus queries and is therefore backwards compatible.