Tell glog to log everything into STDERR. #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Picked some random reviewers; @containous/traefik, feel free to review as desired. :-) |
vdemeester
approved these changes
Jul 3, 2017
emilevauge
approved these changes
Jul 4, 2017
There was a problem hiding this comment.
@vdemeester I wouldn't have said it better:
Interistingly weird, but LGTM 🐸
@timoreimann thanks for this! Could you change the base branch to v1.3 instead ?
Logging errors into a file inside a minimalistic container might not be possible, and glog bails out with an exit code > 0 if it fails.
timoreimann
force-pushed
the
kubernetes/fix-container-crash-on-client-go-error
branch
from
d7073dc
to
1977d96
Compare
|
@emilevauge sure thing 👍 done. |
timoreimann
deleted the
kubernetes/fix-container-crash-on-client-go-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging errors into a file inside a minimalistic container might not be possible, and glog bails out with an exit code > 0 if it fails.
Fixes #1785