Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved namespace to correct place #1911

Merged
merged 1 commit into from
Aug 3, 2017
Merged

Moved namespace to correct place #1911

merged 1 commit into from
Aug 3, 2017

Conversation

markround
Copy link
Contributor

Description

Moves the namespace key to the correct location in the k8s examples. Currently, these fail with a found invalid field namespace for v1.ServiceSpec validation error.

@ldez ldez requested a review from a team August 2, 2017 11:53
timoreimann
timoreimann approved these changes Aug 2, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@ldez ldez added this to the 1.4 milestone Aug 2, 2017
ldez
ldez approved these changes Aug 2, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Aug 3, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 8071f31 into traefik:master Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@timoreimann timoreimann timoreimann approved these changes

@juliens juliens juliens approved these changes

@errm errm Awaiting requested review from errm

@dtomcej dtomcej Awaiting requested review from dtomcej

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/ingress
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@markround @juliens @timoreimann @ldez