Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/k8s: fix ui ingress port out of sync with deployment #1943

Merged
merged 1 commit into from
Aug 17, 2017
Merged

examples/k8s: fix ui ingress port out of sync with deployment #1943

merged 1 commit into from
Aug 17, 2017

Conversation

borancar
Copy link
Contributor

Description

When deploying traefik on my local kubernetes cluster, I saw that the UI didn't display correctly. I narrowed it down to the ingress port mismatch with the traefik deployment.

@borancar borancar requested a review from a team as a code owner August 11, 2017 15:12
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I wonder if we should continue to maintain example files separate from the files referenced in our guides (where existent).

That's for another PR to decide though. This one is perfectly fine and fixes an existing documentation bug.

Thanks @borancar. 👍

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added the size/S label Aug 16, 2017
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants