Fix docs about default namespaces. #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
changed the title
It's not the "default" namespace that's watched if nothing is specified, but "all namespaces".
traefiker
force-pushed
the
k8s-fix-namespaces-docs
branch
from
5b8bb19
to
e0fa0b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not the
defaultnamespace that's watched if nothing is specified, but all namespaces.Proof: Our Namespaces type is a string slice which we use in the Kubernetes provider, and we accept all Ingresses if the slice is empty.
An alternative approach to fixing this would be to really make the
defaultnamespace the default. I don't think that's a good solution though because we probably want users to be able to watch all namespaces if they like to without complete enumeration. In fact, I ran across the doc/code divergence when somebody on Slack asked if it was possible to watch all namespaces, which I was about to deny until I digged into the code.@containous/kubernetes PTAL.