Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Marathon and Kubernetes as constraint-supporting. #1964

Merged
merged 1 commit into from
Aug 18, 2017
Merged

Mark Marathon and Kubernetes as constraint-supporting. #1964

merged 1 commit into from
Aug 18, 2017

Conversation

timoreimann
Copy link
Contributor

Discovered along #1958.

@containous/traefik PTAL.

@ldez ldez added the kind/enhancement a new or improved feature. label Aug 16, 2017
@ldez ldez added this to the 1.4 milestone Aug 16, 2017
ldez
ldez approved these changes Aug 16, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanleary
Copy link
Contributor

Suggest adding that the overriding label for containers is traefik.tags. I can open a separate PR for that if you think it's out of scope here.

@ldez
Copy link
Contributor

ldez commented Aug 17, 2017

@ryanleary I think you can open PR 👍

vdemeester
vdemeester approved these changes Aug 17, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@ldez ldez added the size/S label Aug 17, 2017
nmengin
nmengin approved these changes Aug 17, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the update-list-of-constraint-supporting-providers branch from bfed530 to 00d225e Compare August 18, 2017 00:20
@traefiker traefiker merged commit 3f76f73 into traefik:master Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@ldez ldez ldez approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/ingress area/provider/marathon kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@timoreimann @ryanleary @ldez @vdemeester @nmengin @traefiker