toml page - replace li by table #1995
Conversation
ldez
added
area/documentation
status/2-needs-review
and removed
status/0-needs-triage
labels
There was a problem hiding this comment.
Hi @jmaitrehenry,
thank you for this contribution, I like the table based style much more :)
I added some comments about the parts you added outside of the table transformation. Can you explain those?
docs/toml.md
Outdated
| # | ||
| Cluster = "default" | ||
| Clusters = ["default"] |
There was a problem hiding this comment.
I am confused by this change. I can't see any notion of Clusters in the code. Am I missing something?
There was a problem hiding this comment.
In fact, the current branch seems to be out-of-date with the master.
Only he file docs/toml.md is up-to-date that's why these differences appear.
There was a problem hiding this comment.
Alright, then I will wait for the rebase and have a look again.
docs/toml.md
Outdated
| # Optional | ||
| # Default: false | ||
| # | ||
| AutoDiscoverClusters = false |
There was a problem hiding this comment.
The same as in my previous comment here.
docs/toml.md
Outdated
| @@ -1780,6 +1797,8 @@ Træfik needs the following policy to read ECS information: | |||
| "Sid": "Traefik ECS read access", | |||
| "Effect": "Allow", | |||
| "Action": [ | |||
| "ecs:ListClusters", | |||
There was a problem hiding this comment.
I don't see any calls to ListClusters or DescribeClusters in the ecs provider code.
There was a problem hiding this comment.
@jmaitrehenry Many thanks for your contribution.
Can you rebase please?
jmaitrehenry
force-pushed
the
update_toml_docker_label
branch
from
47fc794
to
43b60af
Compare
|
@nmengin @marco-jantke I just push the rebase In an another PR I will move more li to table if you want. |
|
@jmaitrehenry Could you use a table formatting tool (like tablesgenerator)? |
|
@ldez done |
ldez
changed the title
Related to #1993