Add basic auth for ecs #2026
Add basic auth for ecs #2026
Conversation
ldez
added
area/authentication
status/2-needs-review
kind/enhancement
provider/ecs/ecs_test.go
Outdated
| } | ||
|
|
||
| for _, c := range cases { | ||
| c := c |
There was a problem hiding this comment.
If we rename c to test the complete file will be not consistent.
docs/configuration/backends/ecs.md
Outdated
| | `traefik.frontend.passHostHeader=true` | forward client `Host` header to the backend. | | ||
| | `traefik.frontend.priority=10` | override default frontend priority | | ||
| | `traefik.frontend.entryPoints=http,https` | assign this frontend to entry points `http` and `https`. Overrides `defaultEntryPoints`. | | ||
| | `traefik.frontend.auth.basic=test:$apr1$H6uskkkW$IgXLP6ewTrSuBkTrqE8wj/,test2:$apr1$d9hr9HBB$4HxwgUir3HP4EsggP/QNo0` | Sets basic authentication for that frontend with the usernames and passwords test:test and test2:test2, respectively | |
There was a problem hiding this comment.
could you replace by
| `traefik.frontend.auth.basic=EXPR` | Sets basic authentication for that frontend in CSV format: `User:Hash,User:Hash` |
ldez
force-pushed
the
feature/basic-auth-ecs
branch
from
9e5006d
to
924353a
Compare
provider/ecs/ecs_test.go
Outdated
| } | ||
|
|
||
| for _, test := range cases { | ||
| c := test |
There was a problem hiding this comment.
test := test would work as well. No need to change the variable name.
There was a problem hiding this comment.
You right. A refactoring of ECS provider has been done in #2050. I will do the change to be consistent with this refactoring
| func (p *Provider) getBasicAuth(i ecsInstance) []string { | ||
| label := i.label(types.LabelFrontendAuthBasic) | ||
| if label != "" { | ||
| return strings.Split(label, ",") |
There was a problem hiding this comment.
Do we need/also want to check that each basic auth value adheres to the user:hash? I think we should answer the question with yes if it would simplify reporting an error to the user somehow.
There was a problem hiding this comment.
@ldez This should have been answered prior to merging.
There was a problem hiding this comment.
ldez
added
status/2-needs-review
status/3-needs-merge
and removed
status/3-needs-merge
status/2-needs-review
labels
[ecs] - rename all c to test [ecs] - improve documentation
traefiker
force-pushed
the
feature/basic-auth-ecs
branch
from
439f558
to
6c18aa6
Compare
Description
Implements frontend basic auth for ecs provider.
This addresses the ecs part of #1465