Add Basic auth for consul catalog #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/authentication
status/2-needs-review
kind/enhancement
ldez
suggested changes
Sep 1, 2017
provider/consul/consul_catalog.go
Outdated
| @@ -323,13 +323,22 @@ func (p *CatalogProvider) getBackendName(node *api.ServiceEntry, index int) stri | |||
|
|
|||
| // unique int at the end | |||
| serviceName += "--" + strconv.Itoa(index) | |||
| println("ServiceName: %s", serviceName) | |||
There was a problem hiding this comment.
Yes sure. It was for my tests
ldez
suggested changes
Sep 4, 2017
| | `traefik.frontend.priority=10` | Override default frontend priority | | ||
| | `traefik.frontend.entryPoints=http,https` | Assign this frontend to entry points `http` and `https`. Overrides `defaultEntryPoints`. | | ||
| | `traefik.frontend.auth.basic=test:$apr1$H6uskkkW$IgXLP6ewTrSuBkTrqE8wj/,test2:$apr1$d9hr9HBB$4HxwgUir3HP4EsggP/QNo0` | Sets basic authentication for that frontend with the usernames and passwords test:test and test2:test2, respectively | |
There was a problem hiding this comment.
could you replace by
| `traefik.frontend.auth.basic=EXPR` | Sets basic authentication for that frontend in CSV format: `User:Hash,User:Hash` |
ldez
force-pushed
the
feature/basic-auth-consul-catalog
branch
from
2f41125
to
e173448
Compare
[consul-catalog] - add integration test for basic auth [consul-catalog] - Remove unnecessary println [consul] - improve documentation
ldez
force-pushed
the
feature/basic-auth-consul-catalog
branch
from
e173448
to
81028d1
Compare
ldez
added
priority/P3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements frontend basic auth for consul catalog provider.
This addresses the consul-catalog part of #1465