doc: add notes on server urls with path #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/documentation
status/2-needs-review
and removed
status/0-needs-triage
labels
ldez
suggested changes
Sep 6, 2017
docs/basics.md
Outdated
| @@ -367,7 +367,7 @@ To use a different port for the healthcheck: | |||
|
|
|||
| ### Servers | |||
|
|
|||
| Servers are simply defined using a `URL`. You can also apply a custom `weight` to each server (this will be used by load-balancing). | |||
| Servers are simply defined using a `url`. Note that paths in `url` are not used when sending traffic to the servers; use `Modifer` to specify paths. You can also apply a custom `weight` to each server (this will be used by load-balancing). | |||
There was a problem hiding this comment.
Could you split this line to have one sentence by line?
And change like that:
Servers are simply defined using a `url`.
You can also apply a custom `weight` to each server (this will be used by load-balancing).
!!! note
that paths in `url` are not used when sending traffic to the servers; use `Modifer` to specify paths.
You can check the render of your PR here: https://deploy-preview-2045--traefik-docs.netlify.com/basics/#servers
There was a problem hiding this comment.
I just added !!! note block, and kept the previous lines for minimal changes.
For other changes (like wrapping lines, removing trailing white space) I think it would be better to have separate PR.
|
@ldez updated the target branch to |
traefiker
approved these changes
Sep 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently paths in server
urlis silently ignored, and it makes confusion (see #561 for example). Update the doc to address the limitation.