Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Consul Catalog refresh #2089

Merged
merged 7 commits into from
Sep 8, 2017
Merged

Fix Consul Catalog refresh #2089

merged 7 commits into from
Sep 8, 2017

Conversation

juliens
Copy link
Member

@juliens juliens commented Sep 8, 2017 •
edited by ldez
Loading

fix consul catalog refresh problem when you have multi-nodes services

Thx @mmatur

fixes #1514, #2072

@juliens juliens added this to the 1.4 milestone Sep 8, 2017
@juliens juliens force-pushed the fix/consul-catalog-healthy-nodes branch from b4d89f9 to 6215bfa Compare September 8, 2017 14:07
emilevauge
emilevauge approved these changes Sep 8, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @mmatur 👏
Thanks for finishing it @juliens :)
LGTM

nmengin
nmengin approved these changes Sep 8, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 👏

@juliens juliens force-pushed the fix/consul-catalog-healthy-nodes branch from d3bc64f to ffa6e27 Compare September 8, 2017 15:17
ldez
ldez approved these changes Sep 8, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the fix/consul-catalog-healthy-nodes branch from 7cd4bea to 699fc96 Compare September 8, 2017 16:24
@traefiker traefiker merged commit f80a6ef into traefik:v1.4 Sep 8, 2017
@traefiker traefiker mentioned this pull request Sep 8, 2017
Closed
@ldez ldez mentioned this pull request Sep 8, 2017
Closed
@juliens juliens deleted the fix/consul-catalog-healthy-nodes branch September 13, 2017 13:00
@juliens juliens changed the title Fix consul catalog refresh problems Fix Consul Catalog refresh Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@emilevauge emilevauge emilevauge approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/provider/consulcatalog kind/bug/fix a bug fix size/M
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@juliens @ldez @emilevauge @nmengin @traefiker @mmatur