Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stack name to backend name generation to fix rancher metadata backend #2107

Merged
merged 1 commit into from
Sep 12, 2017

Conversation

SantoDE
Copy link
Collaborator

@SantoDE SantoDE commented Sep 11, 2017

Description

This one fixes #1852 and add's the stack name to the backend name generation to follow the same behavior as in api mode.

You can do a pre test with this docker image:

santode/traefik:issue_1852

Or a dashboard from my dev cluster with 2 services called "whoami" in 2 different stacks:

http://139.59.158.53:8080/dashboard/#/

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants