Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forward auth documentation. #2110

Merged
merged 3 commits into from
Sep 14, 2017
Merged

Add forward auth documentation. #2110

merged 3 commits into from
Sep 14, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Sep 12, 2017

Description

@traefiker traefiker added this to the 1.4 milestone Sep 12, 2017
nmengin
nmengin reviewed Sep 12, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ldez for this missing documentation.
I only have one suggestion, let me know your mind about it.

docs/configuration/entrypoints.md Outdated
[entryPoints.http.auth.forward]
address = "http://authserver.com/auth"
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe can we add a example to describe how to use Forward Authentication with TLS configuration?
WDYT?

juliens
juliens approved these changes Sep 14, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Sep 14, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📖

emilevauge
emilevauge approved these changes Sep 14, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @ldez
LGTM

@traefiker traefiker merged commit 5229b7c into traefik:v1.4 Sep 14, 2017
@ldez ldez deleted the feature/doc-fix-forward-auth branch September 14, 2017 21:57
@ldez ldez mentioned this pull request Sep 17, 2017
Merged
@jkaberg jkaberg mentioned this pull request Sep 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@emilevauge emilevauge emilevauge approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/documentation kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @emilevauge @nmengin @traefiker