Fix deprecated IdleTimeout config #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the --idletimeout or top level idleTimeout setting in the TOML was not respected anymore and not used. This PR fixes this. Also it changes the semantics so that the legacy option is preferred while issuing a warning about the deprecation when its used.
in order to align the process with RespondingTimeouts.
when no interval is specified but the health check is activated via the config.
|
@timoreimann as you were also involved in this, do you want to have a look? :) |
|
Just to be super sure, I'd also test this kind of case: # deprecated option *other* new option specified
idleTimeout="42s"
[respondingTimeouts]
readTimeout="23s"This should cause an effective idle timeout of 42 seconds to be applied. |
|
Thanks for the note Timo. I verified it successfully and added it in my PR description above. |
ldez
added
status/2-needs-review
kind/bug/fix
timoreimann
approved these changes
Sep 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes loading of the deprecated top-level option
IdleTimeout. Also, it changes the semantics so that the deprecated option is now preferred and a warning is logged when it is used.All the different configuration constellations I also verified via the matching CLI parameters as well.
I tried the following configs and they deliver now the expected results:
# default config, nothing specified-> default timeout of 30 seconds is used
-> deprecated option of 42 seconds is used
-> deprecated option of 42 seconds is used
-> deprecated option of 42 seconds is used
-> deprecated option of 42 seconds is used
-> new option of 23 seconds is used
While working on this PR I realized that also the health check has "problems" with its default interval, given it is configured in the following way (imho no one would do such a thing, but still...). As this was at related code places as my change I decided to include it in this PR:
-> interval is initialised with 0 and will lead to
Error in Go routine: non-positive interval for NewTicker