Enable prefix matching within slash boundaries #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
approved these changes
Oct 4, 2017
ldez
added
kind/bug/fix
traefiker
force-pushed
the
enable-prefix-matching-within-slash-boundaries
branch
from
3db8330
to
482daf4
Compare
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables stripping prefixes not only on slash boundaries but also inside of them. The actual mux routing was always capable of routing within the slash boundaries, only the prefix wasn't stripped properly.
Consider we have a fronted rule like
PathPrefixStrip:/statand we are calling Traefik with a Path like/status. This would route the request to the frontend/it's connected backends but the path wouldn't be stripped. With the fix provided in this PR it will properly strip and forward a path like/us.While fixing this problem I realized that the
stripPrefixmiddleware could actually be simplified while keeping all tests working properly.As there was no bug-report by any other Traefik users I am unsure whether we still want to bring this into the 1.4 release. Let me know if I should switch PR to master instead.