-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quote priority values in annotation examples. #2230
Merged
traefiker
merged 1 commit into
traefik:v1.4
from
timoreimann:kubernetes-quote-priority-value-in-examples
Oct 9, 2017
Merged
Quote priority values in annotation examples. #2230
traefiker
merged 1 commit into
traefik:v1.4
from
timoreimann:kubernetes-quote-priority-value-in-examples
Oct 9, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
changed the title
[kubernetes] Quote priority values in annotation examples.
Quote priority values in annotation examples.
Oct 8, 2017
ldez
approved these changes
Oct 9, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nmengin
approved these changes
Oct 9, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐔
juliens
approved these changes
Oct 9, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Otherwise, they'd be interpreted as numbers and rejected/dropped by the API server since annotations must always be strings.
traefiker
force-pushed
the
kubernetes-quote-priority-value-in-examples
branch
from
October 9, 2017 12:04
f9a90d4
to
e2be989
Compare
traefiker
approved these changes
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, they'd be interpreted as numbers and rejected/dropped by the API server since annotations must always be strings.
Refs #2225.