Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote priority values in annotation examples. #2230

Conversation

timoreimann
Copy link
Contributor

Otherwise, they'd be interpreted as numbers and rejected/dropped by the API server since annotations must always be strings.

Refs #2225.

@timoreimann timoreimann requested a review from a team as a code owner October 8, 2017 22:41
@traefiker traefiker added this to the 1.4 milestone Oct 8, 2017
@timoreimann timoreimann changed the title [kubernetes] Quote priority values in annotation examples. Quote priority values in annotation examples. Oct 8, 2017
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added the kind/enhancement a new or improved feature. label Oct 9, 2017
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐔

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Otherwise, they'd be interpreted as numbers and rejected/dropped by the
API server since annotations must always be strings.
@traefiker traefiker force-pushed the kubernetes-quote-priority-value-in-examples branch from f9a90d4 to e2be989 Compare October 9, 2017 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants