Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed Docker network filter to allow any swarm network #2244

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Changed Docker network filter to allow any swarm network #2244

merged 1 commit into from
Oct 13, 2017

Conversation

pistolero
Copy link
Contributor

Changed network filtering parameters in docker provider to allow any swarm scoped network, not only overlay network.

This fixes #2019

@pistolero pistolero requested a review from a team as a code owner October 10, 2017 20:15
@mmatur mmatur changed the title Changed Docker network filter to allow any swarm network. Fixes #2019 Changed Docker network filter to allow any swarm network Oct 10, 2017
nmengin
nmengin approved these changes Oct 13, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 🐳

emilevauge
emilevauge approved these changes Oct 13, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @pistolero !
LGTM

@emilevauge emilevauge added this to the 1.4 milestone Oct 13, 2017
@ldez ldez changed the base branch from master to v1.4 October 13, 2017 09:45
ldez
ldez approved these changes Oct 13, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 8af39bd into traefik:v1.4 Oct 13, 2017
@traefiker traefiker mentioned this pull request Oct 13, 2017
Closed
@danieladams456 danieladams456 mentioned this pull request Oct 18, 2017
Closed
@nmengin nmengin mentioned this pull request Oct 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@emilevauge emilevauge emilevauge approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/provider/docker kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@pistolero @ldez @emilevauge @nmengin @traefiker