Continue processing on invalid auth-realm annotation. #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
added
area/provider/k8s/ingress
kind/bug/fix
emilevauge
approved these changes
Oct 12, 2017
traefiker
force-pushed
the
kubernetes-continue-processing-on-illegal-auth-realm-value
branch
from
c213def
to
533e684
Compare
traefiker
approved these changes
Oct 12, 2017
We previously returned an error, thereby prematurely terminating any further Ingress processing.
traefiker
force-pushed
the
kubernetes-continue-processing-on-illegal-auth-realm-value
branch
from
533e684
to
b028836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously returned an error, thereby prematurely terminating any further Ingress processing.
Fixes #2239.