Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use healthcheck for systemd watchdog #2283

Merged
merged 2 commits into from
Nov 23, 2017
Merged

Use healthcheck for systemd watchdog #2283

merged 2 commits into from
Nov 23, 2017

Conversation

guilhem
Copy link
Contributor

@guilhem guilhem commented Oct 19, 2017

Mutualise code for traefik healthcheck command and watchdog.

Link to first version of watchdog implementation #818

@emilevauge
Copy link
Member

Hey @guilhem, thanks for your contribution :)
Can I ask you what is the real need to check the healthcheck in the systemd watchdog ?

@guilhem
Copy link
Contributor Author

guilhem commented Oct 26, 2017

@emilevauge of course you can :)

Currently, systemd watchdog only tests if a goroutine is working... that's not really a true healthcheck.
The server can be blocked, but watchdog ok.

With this kind of healthcheck, any problem on TCP stack (too many file open) and HTTP server is triggered

@emilevauge
Copy link
Member

Yeah, I understand.
But the healthcheck is not on the same http server than the reverse proxy, so I'm wondering if it's worth it.
WDYT ?

@guilhem
Copy link
Contributor Author

guilhem commented Oct 26, 2017

yes of course, but it's acting like any other healthcheck will do by requesting /ping.

In fact, I only use your work on command line healthcheck and generalize it to be used by systemd watchdog.

Any improvement in healthcheck function can be done :)

@ldez ldez added this to the 1.5 milestone Nov 16, 2017
juliens
juliens approved these changes Nov 23, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Nov 23, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez
ldez approved these changes Nov 23, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Guilhem Lettron and others added 2 commits November 23, 2017 14:56
@traefiker
Use healthcheck for systemd watchdog
1f56682 
Mutualise code for `traefik healthcheck` command and watchdog.
@ldez @traefiker
refactor: use new healthcheck cmd.
44cb113
@traefiker traefiker merged commit 2436874 into traefik:master Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/healthcheck kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
6 participants
@guilhem @emilevauge @juliens @mmatur @ldez @traefiker