Fix healthcheck path #2295
Merged
Fix healthcheck path #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilevauge
force-pushed
the
fix-healthcheck-path
branch
from
eae2d86
to
435fcbd
Compare
nmengin
reviewed
Oct 23, 2017
configuration/configuration.go
Outdated
| } | ||
| if gc.Web.Path[len(gc.Web.Path)-1:] != "/" { | ||
| gc.Web.Path += "/" | ||
| } |
There was a problem hiding this comment.
Can not use a single if block ?
if gc.Web.Path == "" || gc.Web.Path[len(gc.Web.Path)-1:] != "/" {
gc.Web.Path += "/"
}
ldez
suggested changes
Oct 23, 2017
configuration/configuration.go
Outdated
| gc.LogLevel = "DEBUG" | ||
| } | ||
| if gc.Web != nil { | ||
| if gc.Web.Path == "" || gc.Web.Path[len(gc.Web.Path)-1:] != "/" { |
There was a problem hiding this comment.
gc.Web.Path[len(gc.Web.Path)-1:] != "/" can be replace by a !strings.HasSuffix(gc.Web.Path, "/")
There was a problem hiding this comment.
the 2 if can be merged:
if gc.Web != nil && (gc.Web.Path == "" || !strings.HasSuffix(gc.Web.Path, "/")) {
gc.Web.Path += "/"
}
Signed-off-by: Emile Vauge <emile@vauge.com>
Signed-off-by: Emile Vauge <emile@vauge.com>
traefiker
force-pushed
the
fix-healthcheck-path
branch
from
f5d85ef
to
4e4b747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes healthcheck path.
Fixes #2273