Fix IP address when Docker container network mode is container #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmengin
added
status/3-needs-merge
status/2-needs-review
and removed
status/0-needs-triage
status/3-needs-merge
labels
nmengin
force-pushed
the
hotfix/docker-networkmode-container
branch
2 times, most recently
from
394dfdd
to
741f72f
Compare
mmatur
requested changes
Oct 26, 2017
provider/docker/docker.go
Outdated
| if container.NetworkSettings.NetworkMode.IsContainer() { | ||
| dockerClient, err := p.createClient() | ||
| if err != nil { | ||
| log.Warnf("Impossible to get IP address for container %s, error: %s", container.Name, err) |
There was a problem hiding this comment.
Could you replace Impossible to get IP address for container... by Unable to get IP address for container... 🇫🇷
provider/docker/docker.go
Outdated
| ctx := context.Background() | ||
| containerInspected, err := dockerClient.ContainerInspect(ctx, container.NetworkSettings.NetworkMode.ConnectedContainer()) | ||
| if err != nil { | ||
| log.Warnf("Impossible to get IP address for container %s : Failed to inspect container ID %s, error: %s", container.Name, container.NetworkSettings.NetworkMode.ConnectedContainer(), err) |
There was a problem hiding this comment.
Could you replace Impossible to get IP address for container... by Unable to get IP address for container... 🇫🇷
nmengin
force-pushed
the
hotfix/docker-networkmode-container
branch
from
f33b320
to
0ce06b1
Compare
ldez
suggested changes
Oct 27, 2017
integration/docker_test.go
Outdated
| "net/http" | ||
| "os" | ||
| "strings" | ||
| "time" | ||
|
|
||
| "io/ioutil" |
nmengin
force-pushed
the
hotfix/docker-networkmode-container
branch
from
0ce06b1
to
75a8648
Compare
nmengin
force-pushed
the
hotfix/docker-networkmode-container
branch
from
75a8648
to
c710bef
Compare
traefiker
approved these changes
Oct 30, 2017
traefiker
force-pushed
the
hotfix/docker-networkmode-container
branch
from
c710bef
to
d18ea5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows returning an IP address for a Docker container which is in
containernetwork mode.Fixes #756