Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for websocket headers #2379

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

juliens
Copy link
Member

@juliens juliens commented Nov 8, 2017

Add some tests to be sure headers are passed when using websocket

related to #2078

@juliens juliens added this to the 1.5 milestone Nov 8, 2017
@mmatur mmatur added the kind/enhancement a new or improved feature. label Nov 8, 2017
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@traefiker traefiker merged commit f6aa147 into traefik:master Nov 9, 2017
@juliens juliens deleted the test-websocket-headers branch January 25, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/websocket kind/enhancement a new or improved feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants