Manage certificates dynamically in kv store #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
status/1-needs-design-review
kind/enhancement
mmatur
changed the title
|
Hello @dahefanteng . Many thanks for this very useful PR. WDYT about adding end-to-end test for the main KV stores (ETCD and Consul)? |
dahefanteng
force-pushed
the
manage-certs-dynamically-in-kv
branch
2 times, most recently
from
801aeab
to
ef66605
Compare
|
@dahefanteng Could you please fix integration tests and resolve conflicts |
dahefanteng
force-pushed
the
manage-certs-dynamically-in-kv
branch
7 times, most recently
from
4b1c9f0
to
1e5deb2
Compare
|
@nmengin I have fix integration tests and resolve confilicts. |
nmengin
force-pushed
the
manage-certs-dynamically-in-kv
branch
from
fbc9013
to
e0a1dfd
Compare
nmengin
requested changes
Nov 22, 2017
nmengin
force-pushed
the
manage-certs-dynamically-in-kv
branch
from
e0a1dfd
to
aabc4cd
Compare
dahefanteng
force-pushed
the
manage-certs-dynamically-in-kv
branch
from
2bb2a9f
to
e5b8ae7
Compare
|
@nmengin I have added some docs about this,although not too much. |
nmengin
force-pushed
the
manage-certs-dynamically-in-kv
branch
from
e5b8ae7
to
9738d16
Compare
nmengin
force-pushed
the
manage-certs-dynamically-in-kv
branch
from
9738d16
to
ba4107c
Compare
nmengin
approved these changes
Nov 23, 2017
ldez
added
status/3-needs-merge
and removed
status/2-needs-review
status/3-needs-merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
manage tls cert file and key file in the kv store dynamically,so we can add https service without restart traefik
Motivation
almost do the same thing with PR #2401, but this will looks consistent with the other code, and support multi kv store.
More