Run Rancher tests cases in parallel. #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
suggested changes
Nov 18, 2017
provider/rancher/rancher_test.go
Outdated
| } | ||
| for _, test := range testCases { | ||
| test := test | ||
| t.Run("", func(t *testing.T) { |
There was a problem hiding this comment.
Can we use a non-empty first parameter for the test description?
(It's missing elsewhere too.)
There was a problem hiding this comment.
It's hard to name tests that I didn't create. 😉
There was a problem hiding this comment.
How about using indices at least? It's far from ideal but better than nothing.
ldez
force-pushed
the
refactor/rancher-tests
branch
from
e31b9df
to
6ec9a57
Compare
traefiker
approved these changes
Nov 20, 2017
traefiker
force-pushed
the
refactor/rancher-tests
branch
from
06d1a91
to
8f3cc24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Run Rancher tests cases in parallel.
Motivation
Speed up tests.
More