Improve logging output for failing healthchecks #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/healthcheck
kind/enhancement
mmatur
changed the title
m3co-code
force-pushed
the
improve-healthcheck-logging
branch
2 times, most recently
from
25746e7
to
41fa5f9
Compare
|
@mmatur I rebased the changes now and resolved the conflicts. Please write a comment next time when you add this label, you don't get notified for label changes and so I wasn't seeing this now for over a week but was wondering why nothing happens with this PR. |
nmengin
approved these changes
Dec 21, 2017
timoreimann
approved these changes
Jan 3, 2018
traefiker
force-pushed
the
improve-healthcheck-logging
branch
from
41fa5f9
to
3637eaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to understand why health checks failed in the case they do. Therefore I improved the logging output of the health checks, so that you can see whether it was e.g. an http/net issue or a wrong response code.
I also use now the backend name only in the logs. Before, for some logs something like
entryPointName+backendNamewas used, but in most places we seem to log the backend name only.