Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty ip when container is stopped #2478

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Fix empty ip when container is stopped #2478

merged 1 commit into from
Nov 28, 2017

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Nov 28, 2017 •
edited by ldez
Loading

What does this PR do?

Fixes #2459
Now we register only running container.

Related to docker 17.09

More

  • Added/updated tests
  • Added/updated documentation

@mmatur mmatur requested a review from a team as a code owner November 28, 2017 11:09
@traefiker traefiker added this to the 1.4 milestone Nov 28, 2017
nmengin
nmengin approved these changes Nov 28, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ldez
ldez approved these changes Nov 28, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vdemeester
vdemeester approved these changes Nov 28, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

emilevauge
emilevauge approved these changes Nov 28, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 47a5cfb into traefik:v1.4 Nov 28, 2017
@traefiker traefiker mentioned this pull request Nov 28, 2017
Closed
@mmatur mmatur deleted the fix-docker-empty-ip branch November 28, 2017 13:47
@nmengin nmengin mentioned this pull request Dec 6, 2017
Closed
@mmatur mmatur added the kind/bug/fix a bug fix label Dec 6, 2017
@gozer gozer mentioned this pull request Jan 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@emilevauge emilevauge emilevauge approved these changes

@ldez ldez ldez approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
area/provider/docker kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@mmatur @vdemeester @ldez @emilevauge @nmengin @traefiker