-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong default entrypoint and non-existing entrypoint issue #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliens
force-pushed
the
fix-entrypoints
branch
from
November 30, 2017 13:59
fffbd1a
to
33c6889
Compare
mmatur
changed the title
fix wrong defaultentrypoint and unexisting entrypoint issue
Fix wrong defaultentrypoint and unexisting entrypoint issue
Nov 30, 2017
ldez
approved these changes
Nov 30, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mmatur
approved these changes
Nov 30, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nmengin
approved these changes
Nov 30, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
traefiker
force-pushed
the
fix-entrypoints
branch
from
November 30, 2017 14:52
33c6889
to
822adf0
Compare
This was referenced Nov 30, 2017
This was referenced Dec 3, 2017
ldez
changed the title
Fix wrong defaultentrypoint and unexisting entrypoint issue
Fix wrong default entrypoint and nonexisting entrypoint issue
Dec 6, 2017
ldez
changed the title
Fix wrong default entrypoint and nonexisting entrypoint issue
Fix wrong default entrypoint and non-existing entrypoint issue
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix issue when we set only the http entrypoint,
defaultEntrypoints
was no longer[ http ]
, but[]
Fix issue when a frontend use two entrypoints and if the first entrypoint doesn't exist, the frontend is skipped
Motivation
fixes #2494 #680 #427
More