Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong default entrypoint and non-existing entrypoint issue #2501

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

juliens
Copy link
Member

@juliens juliens commented Nov 30, 2017

What does this PR do?

Fix issue when we set only the http entrypoint, defaultEntrypoints was no longer [ http ], but []
Fix issue when a frontend use two entrypoints and if the first entrypoint doesn't exist, the frontend is skipped

Motivation

fixes #2494 #680 #427

More

  • Added/updated tests

@traefiker traefiker added this to the 1.5 milestone Nov 30, 2017
@mmatur mmatur changed the title fix wrong defaultentrypoint and unexisting entrypoint issue Fix wrong defaultentrypoint and unexisting entrypoint issue Nov 30, 2017
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@traefiker traefiker merged commit e27e65e into traefik:v1.5 Nov 30, 2017
@ldez ldez changed the title Fix wrong defaultentrypoint and unexisting entrypoint issue Fix wrong default entrypoint and nonexisting entrypoint issue Dec 6, 2017
@ldez ldez changed the title Fix wrong default entrypoint and nonexisting entrypoint issue Fix wrong default entrypoint and non-existing entrypoint issue Dec 6, 2017
@juliens juliens deleted the fix-entrypoints branch January 25, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants