Fix frontend redirect #2544
Merged
Fix frontend redirect #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
fix/frontend-redirect
branch
from
d9b1594
to
4e749fc
Compare
mmatur
requested changes
Dec 8, 2017
server/server.go
Outdated
| if s.globalConfiguration.EntryPoints[entryPoint.Redirect.EntryPoint] == nil { | ||
| return "", "", fmt.Errorf("unknown target entrypoint %q", entryPoint.Redirect.EntryPoint) | ||
| func (s *Server) buildRedirect(entryPointName string) (string, string, error) { | ||
|
|
There was a problem hiding this comment.
Could you please remove this line ?
ldez
force-pushed
the
fix/frontend-redirect
branch
from
4e749fc
to
1146715
Compare
ldez
force-pushed
the
fix/frontend-redirect
branch
from
1146715
to
226b145
Compare
traefiker
force-pushed
the
fix/frontend-redirect
branch
from
e4e0e7d
to
2c1836c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes frontend redirect when entry point doesn't contain redirect definition.
Motivation
Fixes #2540
Related to #2133
More
Additional Notes