Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isHealthy logic. #2577

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Fix isHealthy logic. #2577

merged 1 commit into from
Dec 18, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Dec 15, 2017

What does this PR do?

fix isHealthy logic for Service Fabric.

Motivation

containous/traefik-extra-service-fabric#19

@ldez ldez added this to the 1.5 milestone Dec 15, 2017
nmengin
nmengin approved these changes Dec 18, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

mmatur
mmatur approved these changes Dec 18, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Dec 18, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 35b5ca4 into traefik:v1.5 Dec 18, 2017
@ldez ldez deleted the fix/sf-healthy branch December 20, 2017 00:05
@ldez ldez changed the title fix isHealthy logic. Fix isHealthy logic. Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/servicefabric kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @mmatur @nmengin @traefiker