Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unnecessary type conversions #2583

Merged
merged 1 commit into from
Dec 18, 2017

Conversation

ferhatelmas
Copy link
Contributor

What does this PR do?

Drops unnecessary type conversions

Motivation

Simpler code.

However, it was repeated many times so I suspect it was done for documentation. If so, let me know and I revert partially or close it.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Found by unconvert linter.

Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it makes the compiler happy, then so am I. :-)

Thanks.

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Many thanks for this clean up PR 😉

@ldez ldez changed the title refactor: drop unnecessary type conversions Drop unnecessary type conversions Dec 18, 2017
@ldez ldez added this to the 1.6 milestone Dec 18, 2017
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 705f3f1 into traefik:master Dec 18, 2017
@ferhatelmas ferhatelmas deleted the drop-type-conversions branch December 18, 2017 15:09
@ferhatelmas
Copy link
Contributor Author

My pleasure, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants