Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all available labels to Docker Backend #2584

Merged
merged 12 commits into from
Dec 20, 2017
Merged

Add all available labels to Docker Backend #2584

merged 12 commits into from
Dec 20, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Dec 18, 2017 •
edited
Loading

What does this PR do?

  • add all available labels (container and services)
    • add passTLSCert label.
    • add HealthCheck labels.
    • add error pages labels.
    • add rate limit labels.
    • add whitelistSourceRange for services
  • enhance template readability
  • enhance template method readability

Motivation

Homogenization of the providers [part2]: all providers must have the same options available.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Several PRs will come after that for each provider.

Fixes #2277, #1286, #2535, #1910

Related to #618, #1465

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Dec 18, 2017
@ldez ldez added this to the 1.6 milestone Dec 18, 2017
@ldez ldez requested a review from a team as a code owner December 18, 2017 10:09
@ldez ldez force-pushed the refactor/labels-docker branch 6 times, most recently from 5398a75 to 9e31e39 Compare December 19, 2017 13:13
@mmatur mmatur changed the title homogenization of the providers [part2]: Docker Homogenization of the providers [part2]: Docker Dec 19, 2017
mmatur
mmatur approved these changes Dec 19, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the title Homogenization of the providers [part2]: Docker Add all available labels to Docker Backend Dec 19, 2017
@ldez ldez force-pushed the refactor/labels-docker branch 3 times, most recently from cf0ec1f to 55bafd2 Compare December 19, 2017 23:53
juliens
juliens approved these changes Dec 20, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖

@traefiker traefiker merged commit a533566 into traefik:master Dec 20, 2017
@ldez ldez deleted the refactor/labels-docker branch December 20, 2017 14:21
@ldez ldez mentioned this pull request Jan 4, 2018
Closed
@ldez ldez mentioned this pull request Jan 30, 2018
Closed
8 tasks
@w3blogfr w3blogfr mentioned this pull request Feb 6, 2018
Closed
@ldez ldez mentioned this pull request Feb 6, 2018
Closed
@steffkes steffkes mentioned this pull request Mar 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/docker kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @mmatur @nmengin @traefiker