Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-marathon #2585

Merged
merged 1 commit into from
Dec 19, 2017

Conversation

timoreimann
Copy link
Contributor

What does this PR do?

Upgrade go-marathon to 03b461696.

Motivation

The updated version of go-marathon brings performance improvement to debug logging, making a non-configured logger a no-op, and consequently reducing heap consumption and GC pressure.

@timoreimann timoreimann requested a review from a team as a code owner December 18, 2017 11:46
@traefiker traefiker added this to the 1.5 milestone Dec 18, 2017
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the title Update go-marathon to 03b461696. Update go-marathon Dec 18, 2017
@ldez ldez added kind/bug/fix a bug fix and removed kind/enhancement a new or improved feature. labels Dec 18, 2017
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This brings a performance improvement to debug logging, making a
non-configured logger a no-op, and consequently reducing heap
consumption and GC pressure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants