-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go-marathon #2585
Merged
traefiker
merged 1 commit into
traefik:v1.5
from
timoreimann:update-go-marathon-to-03b461696
Dec 19, 2017
Merged
Update go-marathon #2585
traefiker
merged 1 commit into
traefik:v1.5
from
timoreimann:update-go-marathon-to-03b461696
Dec 19, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
added
area/provider/marathon
kind/enhancement
a new or improved feature.
status/2-needs-review
labels
Dec 18, 2017
ldez
approved these changes
Dec 18, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ldez
added
kind/bug/fix
a bug fix
and removed
kind/enhancement
a new or improved feature.
labels
Dec 18, 2017
mmatur
approved these changes
Dec 19, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
juliens
approved these changes
Dec 19, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This brings a performance improvement to debug logging, making a non-configured logger a no-op, and consequently reducing heap consumption and GC pressure.
traefiker
force-pushed
the
update-go-marathon-to-03b461696
branch
from
December 19, 2017 14:44
f8a3ea2
to
083c540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrade go-marathon to 03b461696.
Motivation
The updated version of go-marathon brings performance improvement to debug logging, making a non-configured logger a no-op, and consequently reducing heap consumption and GC pressure.