Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesos: Use slave.PID.Host as task SlaveIP. #2590

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Mesos: Use slave.PID.Host as task SlaveIP. #2590

merged 1 commit into from
Dec 20, 2017

Conversation

nemosupremo
Copy link
Contributor

@nemosupremo nemosupremo commented Dec 18, 2017 •
edited by ldez
Loading

What does this PR do?

This is the proper way to set the SlaveIP as done by the underlying mesos-dns helper library

Motivation

Fixes #2545

More

  • Added/updated tests

@ldez ldez changed the title Mesos: Use slave.PID.Host as task SlaveIP. Fixes #2545 Mesos: Use slave.PID.Host as task SlaveIP. Dec 18, 2017
@ldez ldez added the kind/bug/fix a bug fix label Dec 18, 2017
timoreimann
timoreimann approved these changes Dec 19, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks, @nemosupremo.

@timoreimann
Copy link
Contributor

(Note: I don't think there's any documentation to update; the fix is more about an implementation detail to me.)

mmatur
mmatur approved these changes Dec 20, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added this to the 1.5 milestone Dec 20, 2017
@nemosupremo nemosupremo requested a review from a team as a code owner December 20, 2017 10:52
@ldez ldez changed the base branch from master to v1.5 December 20, 2017 10:53
@ldez ldez removed the bot/no-merge label Dec 20, 2017
ldez
ldez approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 3c7c6c4 into traefik:v1.5 Dec 20, 2017
@traefiker traefiker mentioned this pull request Dec 20, 2017
Closed
@deric deric mentioned this pull request Mar 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

@timoreimann timoreimann timoreimann approved these changes

Assignees
No one assigned
Labels
area/provider/mesos kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@nemosupremo @timoreimann @mmatur @ldez @traefiker